Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AdvPaste]Fix utility invocation telemetry calls #34912

Merged
merged 1 commit into from
Sep 18, 2024
Merged

[AdvPaste]Fix utility invocation telemetry calls #34912

merged 1 commit into from
Sep 18, 2024

Conversation

jaimecbernardo
Copy link
Collaborator

Summary of the Pull Request

Fixes the telemetry calls we do when the utility is directly invoked by a shortcut:

  • The telemetry event that we invoke the UI is only activated when Advanced Paste is started.
  • There was no telemetry event called for directly invoked Paste as JSON, Paste as Markdown or Custom actions through a shortcut.

@jaimecbernardo jaimecbernardo merged commit d7a07dc into main Sep 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigloewen-msft craigloewen-msft craigloewen-msft approved these changes

@drawbyperpetual drawbyperpetual drawbyperpetual approved these changes

@ethanfangg ethanfangg Awaiting requested review from ethanfangg

@joadoumie joadoumie Awaiting requested review from joadoumie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaimecbernardo @craigloewen-msft @drawbyperpetual